New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up a pipeline or maven plugin to enforce java format #6727

Open

mqliang opened this issue Mar 29, 2021 · 1 comment

Contributor

mqliang commented Mar 29, 2021 •

edited

Loading

As discussed in #6721

There are lots of files are not formatted properly, engineers often forget to format it before commit. We need either setup a Github workflow/pipeline, or a maven plugin to enforce java format

Some tools may be useful:

CLI tools:

https://github.com/google/google-java-format

Maven plugins:

mqliang mentioned this issue

Pinot SPI refactor (no functionality change) #6721

Merged

3 tasks

Contributor

xiangfu0 commented Mar 29, 2021

Thanks for bringing this up!

+1000 on this, I think a maven plugin should be good enough.

mqliang mentioned this issue

Add spotless maven plugin to enforce java format. #6782

Merged

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment