Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea: Enable oss-fuzz support for Reader and Writer #1250

Closed
Xuanwo opened this issue Jan 28, 2023 · 10 comments
Closed

idea: Enable oss-fuzz support for Reader and Writer #1250

Xuanwo opened this issue Jan 28, 2023 · 10 comments

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Jan 28, 2023

It's worth running fuzz tests upon oss-fuzz


This issue is an OSPP task

@Xuanwo Xuanwo changed the title idea:Enable oss-fuzz support for ObjectReader idea: Enable oss-fuzz support for ObjectReader Jan 28, 2023
@ClSlaid

This comment was marked as outdated.

@ClSlaid ClSlaid self-assigned this Mar 20, 2023
@Xuanwo

This comment was marked as outdated.

@Xuanwo

This comment was marked as outdated.

@Xuanwo Xuanwo added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 17, 2023
@Gnosnay
Copy link
Contributor

Gnosnay commented Apr 27, 2023

Hi, team, Can I have one try on this? it looks so interesting.
But I dont have so much time in the day but night... so I may need more time on that.

So May I? Please feel free to let me know any concerns from you, thx!

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 28, 2023

Hello, @Yansongsongsong. Thank you for your interest! However, we have already submitted this issue as an OSPP project. Would you be interested in taking on this project as a student?

More details could be found at https://summer-ospp.ac.cn/org/orgdetail/111e2fe9-025b-46da-a6c5-1b0de297abdd?lang=en

@Xuanwo Xuanwo changed the title idea: Enable oss-fuzz support for ObjectReader idea: Enable oss-fuzz support for Reader and Writer Apr 28, 2023
@Gnosnay
Copy link
Contributor

Gnosnay commented Apr 28, 2023

Hello, @Yansongsongsong. Thank you for your interest! However, we have already submitted this issue as an OSPP project. Would you be interested in taking on this project as a student?

More details could be found at https://summer-ospp.ac.cn/org/orgdetail/111e2fe9-025b-46da-a6c5-1b0de297abdd?lang=en

i dont really care about which role i am to make a contribution. but i am not a student any more. if it is acceptable. i am okay actually.

BTW the link you give here is not open for application.

Here is my plan for this issue:

  1. make one pull request for oss-fuzz
  2. cuz the previous title is ObjectReader, i read a bit about behavior testing in tests folder. I plan to give some documentation for this part.
  3. Then fuzz target related. There are two ways:
    • maintain the fuzz target on oss-fuzz side. just like redis-rs .
      • pros & cons: no need to pull the whole opendal. but the code is maintained seperatedly.
    • maintain the fuzz target in openadal project, just like flate2-rs.
      • pros & cons: easy to maintain it for us. but during the building, it may need to pull all opendal. some stroage and network cost happens here.
  4. Then make the whole workflow work. There are some problems for the whole workflow integration:
    • Contact for oss-fuzz org. AFAIK, oss-fuzz side needs one contact who is really charge of this project. I think it should be the problem for communication and collaboration. let us see how to resolve it.
    • issue tracking. As oss-fuzz said, finally they will create one issue like JIRA ticket staff for us to reminder that we need to fix related problem. We may need to design one proper workflow to track these issues.
    • issue fixing. Same to above, we may give one proper workflow to know the issue, fix the issue and remind oss-fuzz side we have finished issue.

i just review the process roughly, so the plan may not be correct. Feel free to correct me and let me know your concern if you have.

For me i am free to seek the another issue is suitable for me to work with if this issue has been assigned to someone from OSPP activity.

thank you again for your help.

@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 28, 2023

  • maintain the fuzz target in opendal project, just like flate2-rs.

We shold do this at our side.

For me i am free to seek the another issue is suitable for me to work with if this issue has been assigned to someone from OSPP activity.

I apologize for not updating the issue description earlier. Please feel free to take a look at other issues.

@Gnosnay
Copy link
Contributor

Gnosnay commented Apr 28, 2023

  • maintain the fuzz target in opendal project, just like flate2-rs.

We shold do this at our side.

For me i am free to seek the another issue is suitable for me to work with if this issue has been assigned to someone from OSPP activity.

I apologize for not updating the issue description earlier. Please feel free to take a look at other issues.

no worries. take it easy.

@Xuanwo Xuanwo removed good first issue Good for newcomers help wanted Extra attention is needed labels Jun 26, 2023
@dqhl76
Copy link
Member

dqhl76 commented Jun 27, 2023

Thanks for @Yansongsongsong's plan and @Xuanwo's explanation.
I create a issue #2551 to track the implementation process.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 25, 2023

Tracked in #2551

@Xuanwo Xuanwo closed this as completed Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants