Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTTPS workaround added in #6673 #6680

Open
mbien opened this issue Nov 9, 2023 · 4 comments
Open

Remove HTTPS workaround added in #6673 #6680

mbien opened this issue Nov 9, 2023 · 4 comments
Labels
CI continuous integration changes Gradle [ci] enable "build tools" tests LSP [ci] enable Language Server Protocol tests Micronaut [ci] enable enterprise job tests
Milestone

Comments

@mbien
Copy link
Member

mbien commented Nov 9, 2023

The problem will likely resolve itself (due to updates in tested gradle versions or other means), once it is working again, remove the workaround added in #6673

See first //TODO in MicronautGradleArtifactsImplTest and ProjectViewTest (c0f09c9)

@mbien mbien added the Gradle [ci] enable "build tools" tests label Nov 9, 2023
@mbien mbien added this to the NB21 milestone Nov 9, 2023
@mbien mbien added the tests label Nov 11, 2023
@mbien
Copy link
Member Author

mbien commented Nov 30, 2023

found

System.setProperty("javax.net.debug", "ssl:handshake");

to be useful for SSL debugging. But it produces a lot of output with is mixed with the test output which is also a lot. Would be interesting to diff the two https handshake logs of the gradle Downloader with and without the workaround.

exception snippet taken from the PR:

Caused by: javax.net.ssl.SSLHandshakeException: Received fatal alert: handshake_failure
	at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:131)
	at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:117)
	at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:347)
	at java.base/sun.security.ssl.Alert$AlertConsumer.consume(Alert.java:293)
	at java.base/sun.security.ssl.TransportContext.dispatch(TransportContext.java:186)
	at java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:172)
	at java.base/sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1511)
	at java.base/sun.security.ssl.SSLSocketImpl.readHandshakeRecord(SSLSocketImpl.java:1421)
	at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:456)
	at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:427)
	at java.base/sun.net.www.protocol.https.HttpsClient.afterConnect(HttpsClient.java:580)
	at java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:201)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.followRedirect0(HttpURLConnection.java:2830)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.followRedirect(HttpURLConnection.java:2742)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1869)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1525)
	at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:250)
	at org.gradle.wrapper.Download.downloadInternal(Download.java:129)
	at org.gradle.wrapper.Download.download(Download.java:109)

@neilcsmith-net neilcsmith-net modified the milestones: NB21, NB22 Jan 30, 2024
@mbien

This comment was marked as outdated.

@mbien
Copy link
Member Author

mbien commented Feb 2, 2024

sorry about the noise, I ran the wrong tests and got excited too fast.

@ebarboni ebarboni modified the milestones: NB22, NB23 Apr 19, 2024
@mbien mbien modified the milestones: NB23, NB24 Jul 16, 2024
@mbien mbien modified the milestones: NB24, NB25 Oct 11, 2024
@mbien mbien added the CI continuous integration changes label Oct 11, 2024
@mbien
Copy link
Member Author

mbien commented Oct 11, 2024

higher priority than this would be to get gradle tests testable on 21+, since they are locked to JDK 17 atm. I still hope that things like this resolve themself via dependency updates.

Once the latest wrappers+gradle is used we can take another look. Also tracked via #7871

@mbien mbien modified the milestones: NB25, NB26 Jan 15, 2025
@mbien mbien added LSP [ci] enable Language Server Protocol tests Micronaut [ci] enable enterprise job labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration changes Gradle [ci] enable "build tools" tests LSP [ci] enable Language Server Protocol tests Micronaut [ci] enable enterprise job tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants