Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up: Migrate Wildfly connectivity to use jboss-modules #6193

Open
asbachb opened this issue Jul 13, 2023 · 4 comments
Open

Follow-up: Migrate Wildfly connectivity to use jboss-modules #6193

asbachb opened this issue Jul 13, 2023 · 4 comments
Assignees
Labels
enterprise [ci] enable enterprise job Java EE/Jakarta EE [ci] enable enterprise job kind:feature A feature request

Comments

@asbachb
Copy link
Collaborator

asbachb commented Jul 13, 2023

Description

We're currently use jboss-cli-client.jar in order to get connectivity to Wildfly remote admin. This jar is a kind of uber jar containing all kind of unnecessary classes to fulfill this connectivity.

In the PR introducing the dependency to jboss-cli-client.jar it was supposed to integrate jboss-modules in order to pull only jar files which are necessary.

see #6138 for more details on that discussion

Use case/motivation

No response

Related issues

No response

Are you willing to submit a pull request?

No

@asbachb asbachb added Java EE/Jakarta EE [ci] enable enterprise job kind:feature A feature request enterprise [ci] enable enterprise job labels Jul 13, 2023
@ehsavoie
Copy link
Contributor

I'm wondering if the simplest solution would be to provide the jar from wildfly-core that we need since those are ASL 2.0. That would be the easiest way as they should be retro-compatible and WildFly team ensure the forward compatibility. We would also be able to get rid of the current reflection code.
Be aware that with the current galleon provisioning of WildFly the jboss-client might not be there anymore too.

@ehsavoie
Copy link
Contributor

@asbachb @mbien WDYT ?

@asbachb
Copy link
Collaborator Author

asbachb commented Jul 19, 2023

Actually I'm not 100% sure what consequences are when providing (you mean the module should ship it as dependency?). I don't like the reflection code either. I guess the new solution should be easy to understand and to maintain. Ideally we don't need to touch the code for new releases.
I guess nobody want a solution back where somebody needs to handpick some random jars which needs to be different for different versions.

@ehsavoie
Copy link
Contributor

Yes I mean to add the required jars as dependencies. I know that they used to do it that way in jboss-tools and in the wildfly-maven-plugin. I know that WildFly team is extra carefull to be retro-compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enterprise [ci] enable enterprise job Java EE/Jakarta EE [ci] enable enterprise job kind:feature A feature request
Projects
None yet
Development

No branches or pull requests

2 participants