Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

test_operator.test_rnnrelu_bidirectional has fixed seed that can mask flakiness #11722

Closed
szha opened this issue Jul 13, 2018 · 3 comments
Closed

Comments

@szha
Copy link
Member

szha commented Jul 13, 2018

The unit test in title have been using fixed seed to mask flakiness. Suggested action:

  1. Evaluate whether the test is flaky without fixed seed. If not, remove seed. Else move to 2
  2. If test is flaky, determine whether it's an actual uncaught edge case. If so, fix the operator. Else move to 3
  3. If numerical instability is inevitable, adjust tolerance level appropriately.
@apeforest
Copy link
Contributor

@szha Thanks for filing this issue. We will investigate these Flaky tests.

@haojin2
Copy link
Contributor

haojin2 commented Jul 13, 2018

This is a disabled test tracked at #11410.

@szha
Copy link
Member Author

szha commented Jul 13, 2018

Duplicate of #11410

@szha szha marked this as a duplicate of #11410 Jul 13, 2018
@szha szha closed this as completed Jul 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants