-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gradlew check
fails checksum validation in a fresh clone on Windows
#12961
Comments
In addition to the checksum problem |
I'm sorry, but I disagree with this. I'm using Windows myself all the time but the automatic conversion of line ends is the most weird and annoying feature ever conceived. It can be turned off, please do turn it off, then clone the repository again. |
To work with this repository the files must have LF line breaks. Why not make that part of the repository itself? There is a |
With |
At the very least the contributing guide needs to mention that one should set the config while cloning the repo: |
Apparently,
|
I won't stand in the way if others want those .gitattributes - I just expressed my opinion. Do yourself a favor and switch it off globally, really. This should be the default on Windows. I've spent countless hours trying to figure out why git checked out something that really wasn't there (at least not for anybody else on the planet) - this happens over and over again if you have automatic conversions in place.
At least they know that what they've checked in is the same as what they have locally, byte-to-byte. As a Windows user myself, I don't see this as a bigger harm than git replacing stuff for me automatically. And nobody can convince me otherwise, sorry. |
Perl and python3 (in many cases, not sure whether it's required for tasks check depends on). |
I don't like these conversions, that's about it. I like to get out what I put in. Consider this example if you need one (hexdump it) - |
I'm with you on not liking this behavior, actually. Shall I submit a PR for contributing guide with a "remark for Windows users" and a "Pre-requisites" section? |
I think any programmer on Windows has been through this. I don't know why git defaults are such on Windows - maybe git folks want Windows users to be miserable (as if being forced to use ntfs wasn't enough)... Again - I can be sour about it because I'm actually a Windows user myself (or rather - multi-system user).
Please do and thank you! |
Description
By default Git uses CR LF line breaks in checked out text files on Windows. And this causes mismatch of the checksums that were calculated for files with LF line breaks.
Either checksum calculation should be made line breaks agnostic. Or "proper" LF line breaks should be pre-enforced on Windows too, e.g. via
.gitattributes
:Gradle command to reproduce
gradlew check
The text was updated successfully, but these errors were encountered: