Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplication computation for TieredMergePolicy's numDeletesToMerge [LUCENE-10041] #11079

Closed
asfimport opened this issue Jul 29, 2021 · 3 comments
Closed

Duplication computation for TieredMergePolicy's numDeletesToMerge [LUCENE-10041] #11079

asfimport opened this issue Jul 29, 2021 · 3 comments
Assignees
@dnhatn
Labels
affects-version:8.4 legacy-jira-priority:Minor module:core/index type:enhancement

Comments

@asfimport
Copy link

In lucene 8.4 (Elasticsearch 7.6.2), all indices are enabled with soft-deletes. We found the TieredMergePolicy contains redundant query computation to acquire numDeletesToMerge for findMerges. According to code from getSortedBySegmentSize , I think we should reuse the result of numDeletesToMerge which can reduce 3% CPU and some IO overheads.

 
.

IMG21.jpeg

Migrated from LUCENE-10041 by Feng Gui, updated Aug 16 2021
Attachments: IMG21.jpeg
@asfimport
Copy link
Author

Feng Gui (migrated from JIRA)

#231

@asfimport
Copy link
Author

Feng Gui (migrated from JIRA)

hi @dnhatn, can you help to review above pr?  thx.

@dnhatn
Copy link
Member

dnhatn commented May 1, 2024

Fixed in #12339

@dnhatn dnhatn closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnhatn dnhatn

Labels
affects-version:8.4 legacy-jira-priority:Minor module:core/index type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dnhatn @asfimport