[BYOC][JSON] json_node.h should include data_type.h #6224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes compilation issue after apache#6214. Change-Id: I07e25356bbfe4a7bd0950f2672441ce1c338dc3f
comaniac
approved these changes
Aug 6, 2020
zhiics
approved these changes
Aug 6, 2020
tqchen
approved these changes
Aug 6, 2020
wjliu1998
pushed a commit
to wjliu1998/incubator-tvm
that referenced
this pull request
Aug 13, 2020
Fixes compilation issue after apache#6214. Change-Id: I07e25356bbfe4a7bd0950f2672441ce1c338dc3f
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
Fixes compilation issue after apache#6214. Change-Id: I07e25356bbfe4a7bd0950f2672441ce1c338dc3f
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
Fixes compilation issue after apache#6214. Change-Id: I07e25356bbfe4a7bd0950f2672441ce1c338dc3f
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
Fixes compilation issue after apache#6214. Change-Id: I07e25356bbfe4a7bd0950f2672441ce1c338dc3f
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
Fixes compilation issue after apache#6214. Change-Id: I07e25356bbfe4a7bd0950f2672441ce1c338dc3f
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
Fixes compilation issue after apache#6214. Change-Id: I07e25356bbfe4a7bd0950f2672441ce1c338dc3f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json_node uses the function String2DLDataType which an be found in data_type.h. #6214 reshuffled a few includes in container.h which meant String2DLDataType could not be found during compilation.
cc @comaniac @zhiics @tqchen