Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay][Bug] Fix what looks like bizzare copy-paste issue #6010

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

jroesch
Copy link
Member

@jroesch jroesch commented Jul 7, 2020

Fix a weird double namespacing on visitor methods cc @mbrookhart and @tqchen that was reported this morning.

Copy link
Contributor

@mbrookhart mbrookhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't figure out how it compiled with the double namespace...but this has been in the codebase for almost 2 years...

Anyway, LGTM

@tqchen tqchen merged commit 0dd8631 into apache:master Jul 8, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jul 14, 2020
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jul 14, 2020
@jroesch jroesch deleted the visitor-fix branch February 4, 2021 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants