Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docker/bash.sh to handle git worktrees #5970

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

areusch
Copy link
Contributor

@areusch areusch commented Jun 30, 2020

The lint tool doesn't mount the correct .git directory into the docker image when using git-worktree. Adding support for that.

@areusch areusch changed the title Improve docker/bash script to handle git worktrees Improve docker/bash.sh to handle git worktrees Jun 30, 2020
@areusch areusch changed the title Improve docker/bash.sh to handle git worktrees Improve docker/bash.sh to handle git worktrees Jun 30, 2020
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@tqchen tqchen merged commit dd78036 into apache:master Jul 1, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jul 1, 2020
* improve error code when git ls-files fails

* fix docker/bash to handle git worktrees
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Jul 2, 2020
* improve error code when git ls-files fails

* fix docker/bash to handle git worktrees
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants