Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional canonicalization added for AddNode #5846

Merged
merged 2 commits into from
Jun 18, 2020

Conversation

ANSHUMAN87
Copy link
Contributor

The PR has 2 issue fix:
1: 2 + x was always operated as x + 2. It hides certain match condition.
2: Canonicalize (c1 - y) + x --> (x - y) + c1

cc @yzhliu , @zhiics , @tqchen

@tqchen tqchen merged commit 24df0ba into apache:master Jun 18, 2020
@tqchen
Copy link
Member

tqchen commented Jun 18, 2020

thanks @ANSHUMAN87

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 30, 2020
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants