Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LRN only supports 4D tensors, remove it from alter_op_layout #5520

Merged
merged 1 commit into from
May 6, 2020

Conversation

mbrookhart
Copy link
Contributor

LRN only supports 4D tensors, so we shouldn't propogate novel layouts through it. This change fixes crashes with a number of models in the ONNX Model Zoo that use LRN.

@merrymercy Git blame says you wrote this line 17 months ago, mind reviewing? Thanks!

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbrookhart for the bug fix

@tmoreau89 tmoreau89 requested a review from merrymercy May 6, 2020 16:20
@tmoreau89
Copy link
Contributor

@merrymercy if you can review this change by the end of the day thanks!

@tqchen tqchen merged commit 79e29ab into apache:master May 6, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 9, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 18, 2020
@mbrookhart mbrookhart deleted the mbrookhart/alter_op_layout branch December 3, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants