Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hexagon] Change "scalar" and "stack" in IDL from "inrout" to "in" #5487

Merged
merged 1 commit into from
May 1, 2020
Merged

[Hexagon] Change "scalar" and "stack" in IDL from "inrout" to "in" #5487

merged 1 commit into from
May 1, 2020

Conversation

kparzysz-quic
Copy link
Contributor

This changes the scalar and stack parameters to kernel to be input parameters only, as suggested by @FrozenGene .

@FrozenGene
Copy link
Member

Thanks @kparzysz-quic . As we talked in #5353, you mention that if we change to in, maybe cause cache/memory synchronization issue. Within this pr, means we have done the test and verify it has no problem, right?

@kparzysz-quic
Copy link
Contributor Author

Yes, we have tested this change.

@FrozenGene FrozenGene merged commit 3f33b25 into apache:master May 1, 2020
@FrozenGene
Copy link
Member

Thanks ! @kparzysz-quic

@kparzysz-quic kparzysz-quic deleted the idl.in branch May 1, 2020 12:40
Laurawly pushed a commit to Laurawly/tvm-1 that referenced this pull request May 9, 2020
…pache#5487)

Co-authored-by: Abhikrant Sharma <quic_abhikran@quicinc.com>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 9, 2020
…pache#5487)

Co-authored-by: Abhikrant Sharma <quic_abhikran@quicinc.com>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 18, 2020
…pache#5487)

Co-authored-by: Abhikrant Sharma <quic_abhikran@quicinc.com>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 18, 2020
…pache#5487)

Co-authored-by: Abhikrant Sharma <quic_abhikran@quicinc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants