[FRONTEND][MXNET] Use leaky by default for LeakyReLU #5192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
LGTM other than one Test cases refactor comment. Thanks @kazum
| data = mx.sym.concat(data, -data, dim=1) # negative part explicitly | ||
| mx_sym = mx.sym.LeakyReLU(data) | ||
| verify_mxnet_frontend_impl(mx_sym, (1, 3, 100, 100), (1, 6, 100, 100)) | ||
| mx_sym = mx.sym.LeakyReLU(data, act_type='leaky') |
There was a problem hiding this comment.
All other existing Relu test cases seem to follow same pattern. Can we refactor them to a single function?
There was a problem hiding this comment.
The only leaky relu has two patterns to be applied. Having two tests for it looks good to me.
maheshambule
approved these changes
Apr 1, 2020
tqchen
approved these changes
Apr 1, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f. https://mxnet.apache.org/api/python/docs/api/symbol/symbol.html#mxnet.symbol.LeakyReLU
@maheshambule @alexgl-github @kevinthesun Could you review?