[RUNTIME]crt error handling #5147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangfu
requested changes
Mar 26, 2020
There was a problem hiding this comment.
@siju-samuel Thanks for bringing the improvements. I think we still need to follow MISRA-C rules as closely as possible. Specifically, we should have only one return statement in a function.
src/runtime/crt/graph_runtime.c
Outdated
| reader->BeginArray(reader); | ||
| if (!(reader->NextArrayItem(reader))) { | ||
| fprintf(stderr, "invalid json format: failed to parse `node_id`\n"); | ||
| return status; |
There was a problem hiding this comment.
MISRA-C requires having only one return statement in a function.
src/runtime/crt/graph_runtime.c
Outdated
| @@ -38,25 +38,28 @@ uint32_t Shape_Accumulate(int64_t * shape, uint32_t ndim) { | |||
| } | |||
|
|
|||
| int NodeEntry_Load(TVMGraphRuntimeNodeEntry * entry, JSONReader * reader) { | |||
| int status = 0; | |||
| int status = -1; | |||
There was a problem hiding this comment.
The default is intended to be success, and set status to error when we are in trouble. Subsequently, return status at the end of the function.
|
Thanks @siju-samuel for the changes |
tmoreau89
approved these changes
Mar 26, 2020
|
Thanks @liangfu @siju-samuel the PR has been merged. |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
* crt error handling * Review comments fixed
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
* crt error handling * Review comments fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@liangfu @tmoreau89 Please help to review. TIA
Most of the places error was not returned to caller and the function will continue to execute and cause some exception. This is handled.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.