[External Codegen] Fix annotate pass static variable #5023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiics
approved these changes
Mar 10, 2020
comaniac
approved these changes
Mar 11, 2020
'fannotate' in the annotate_target pass was designated as static. This meant that if you use the pass to annotate more than one codegen, its value is not updated when the target changes resulting in incorrect annotation. Change-Id: Ib4f3af5cfbef44f29771818219755198ac313a0e
zhiics
added
status: accepted
and removed
status: need update
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
'fannotate' in the annotate_target pass was designated as static. This meant that if you use the pass to annotate more than one codegen, its value is not updated when the target changes resulting in incorrect annotation. Change-Id: Ib4f3af5cfbef44f29771818219755198ac313a0e
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
'fannotate' in the annotate_target pass was designated as static. This meant that if you use the pass to annotate more than one codegen, its value is not updated when the target changes resulting in incorrect annotation. Change-Id: Ib4f3af5cfbef44f29771818219755198ac313a0e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'fannotate' in the annotate_target pass was designated as static. This meant that if you use the pass to annotate more than one codegen, its value is not updated when the target changes resulting in incorrect annotation.