Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onnx import bugs #4750

Merged
merged 2 commits into from
Feb 11, 2020
Merged

Fix onnx import bugs #4750

merged 2 commits into from
Feb 11, 2020

Conversation

kice
Copy link
Contributor

@kice kice commented Jan 20, 2020

Fix onnx attributes of string type incorrect handling
Merge symmetric padding of Conv to symmetric form

ref: #4566 (comment)

Fix onnx attributes of string type incorrect handling
Merge symmetric padding of Conv to symmetric form
Copy link
Contributor

@jwfromm jwfromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the CI issue is fixed. Thanks for fixing these!

@kice
Copy link
Contributor Author

kice commented Jan 24, 2020

@tqchen @jwfromm Please review the new changes

@tqchen
Copy link
Member

tqchen commented Jan 25, 2020

@kice it would be great if you can add a testcase that covers this corner case

@tqchen
Copy link
Member

tqchen commented Feb 6, 2020

ping @kice can you please add a few testcases?

@tqchen tqchen removed status: need review status: need test case need test cases to cover the change labels Feb 11, 2020
@tqchen tqchen merged commit 54349ec into apache:master Feb 11, 2020
@tqchen
Copy link
Member

tqchen commented Feb 11, 2020

Merge it for now to avoid staleness, and given that the code is properly reviewed. @kice @jwfromm would be great to add a followup PR to cover the case

alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
* Fix onnx import bugs

Fix onnx attributes of string type incorrect handling
Merge symmetric padding of Conv to symmetric form

* Only merge symmetric padding for conv2d
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
* Fix onnx import bugs

Fix onnx attributes of string type incorrect handling
Merge symmetric padding of Conv to symmetric form

* Only merge symmetric padding for conv2d
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
* Fix onnx import bugs

Fix onnx attributes of string type incorrect handling
Merge symmetric padding of Conv to symmetric form

* Only merge symmetric padding for conv2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants