Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @superset-ui/colors #6464

Merged
merged 3 commits into from
Nov 30, 2018
Merged

Update @superset-ui/colors #6464

merged 3 commits into from
Nov 30, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Nov 29, 2018

Bump the package version to 0.7.0 and update calls according to new API changes.

  • Remove categoricalColorScale.toFunction(). Now categoricalColorScale itself is already a function.
  • Rename ColorScheme field name to id.

@williaster @conglei @xtinec @michellethomas @graceguo-supercat

@codecov-io
Copy link

codecov-io commented Nov 29, 2018 •
edited
Loading

Codecov Report

Merging #6464 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6464   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files          67       67           
  Lines        9591     9591           
=======================================
  Hits         7032     7032           
  Misses       2559     2559

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e715cdb...f821740. Read the comment docs.

williaster
williaster approved these changes Nov 30, 2018
View reviewed changes
Copy link
Contributor

@williaster williaster left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!! 🎨🎨🎨

@kristw kristw merged commit 20e1ac6 into apache:master Nov 30, 2018
@kristw kristw deleted the kristw--update-superset-ui branch November 30, 2018 17:50
@kristw kristw added v0.30 and removed reviewable labels Nov 30, 2018
mistercrunch pushed a commit that referenced this pull request Dec 5, 2018
@kristw @mistercrunch
Update @superset-ui/colors (#6464)
3bede69 
* Update package version and update breaking changes for color

* update color function usage

* update dependency

(cherry picked from commit 20e1ac6)
bipinsoniguavus pushed a commit to ThalesGroup/incubator-superset that referenced this pull request Dec 26, 2018
@kristw @bipinsoniguavus
Update @superset-ui/colors (apache#6464)
f12f1c4 
* Update package version and update breaking changes for color

* update color function usage

* update dependency
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 27, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@kristw @mistercrunch
Update @superset-ui/colors (apache#6464)
547abb7 
* Update package version and update breaking changes for color

* update color function usage

* update dependency

(cherry picked from commit 9114409)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels v0.29 v0.30 🚢 0.34.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kristw @codecov-io @williaster @mistercrunch