[fix] JS error after delete row level tab #6393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
approved these changes
Nov 15, 2018
Codecov Report
@@ Coverage Diff @@
## master #6393 +/- ##
=======================================
Coverage 77.31% 77.31%
=======================================
Files 67 67
Lines 9581 9581
=======================================
Hits 7408 7408
Misses 2173 2173Continue to review full report at Codecov.
|
|
thanks @graceguo-supercat for this fix! |
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Nov 16, 2018
(cherry picked from commit ec1316a)
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
Nov 20, 2018
(cherry picked from commit ec1316a)
mistercrunch
pushed a commit
that referenced
this pull request
Nov 30, 2018
(cherry picked from commit ec1316a)
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
mistercrunch
added
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit 37013dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This JS error only shows when user deletes row-level tab from dashboard:
Fix: adding null check when creating DashboardComponent.
@williaster @michellethomas @kristw