Geoviz state management fix #6260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
+1 on new changes |
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 8, 2018
* Fix deckgl getPoints * Fix CSS * Fix zoom * Fix CategoricalDeckGLContainer * Fix cypress (cherry picked from commit a57603a)
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
* Fix deckgl getPoints * Fix CSS * Fix zoom * Fix CategoricalDeckGLContainer * Fix cypress
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we added more interactivity to the geospatial visualizations, like selecting multiple polygons and the play slider, the components need to store and manage their own state. The state was being computed from the props at the constructor, but it needs to be recomputed for some changes in the props — namely, when the payload changes.
I also fixed the CSS for the play slider, so it works consistently in the Explore view and in dashboards.