-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the filter dropdown choices in the Filter Box cascading #5664
Make the filter dropdown choices in the Filter Box cascading #5664
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5664 +/- ##
==========================================
+ Coverage 63.49% 64.02% +0.52%
==========================================
Files 360 361 +1
Lines 22889 22940 +51
Branches 2549 2557 +8
==========================================
+ Hits 14534 14687 +153
+ Misses 8340 8238 -102
Partials 15 15
Continue to review full report at Codecov.
|
Sorry that this PR got ignored so far. It's great work but as you know there's ongoing work in redesigning filters as dashboard native components and if we want to deprecate filter box, we may want (but not necessarily have to) to keep it as simple as possible. @xtinec (working on filters) |
Yeah I definitely understand we probably don't want to introduce new functionality at the moment. I'll close this for now. @xtinec let me know if you want to chat about how it works if you decide to integrate cascading filter options! |
@emlittleworth love to chat about cascading filter options and incorporate it into the new design! |
@emlittleworth I'm interested to chat about it as well. How can we get in touch? |
@emlittleworth i'm also interested as well! are there any updates or is there any feedback i can contribute? |
@xtinec and @emlittleworth - is this something that's still in progress? |
Chiming in: Would definitely love this feature to be put up in Superset. |
@emlittleworth or @xtinec or @mistercrunch Did this feature or something similar ever get finished? |
When a user selects a filter in the Filter Box visualization, the following filter dropdowns will be filtered based on that selection. It does not currently take the Filter Box time filter into consideration. I had to pull the
FilterBox
component into it's own file in order to export it for testing.Before:
![before](https://user-images.githubusercontent.com/4187958/44290285-0b8cfe00-a246-11e8-9718-f821225278a9.png)
After:
![after](https://user-images.githubusercontent.com/4187958/44290290-1051b200-a246-11e8-8123-17ad75ff4f76.png)
Related issues: #5269, #5043, #4421, #3015, #5534