Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the filter dropdown choices in the Filter Box cascading #5664

Closed

Conversation

emlittleworth
Copy link
Contributor

@emlittleworth emlittleworth commented Aug 17, 2018

When a user selects a filter in the Filter Box visualization, the following filter dropdowns will be filtered based on that selection. It does not currently take the Filter Box time filter into consideration. I had to pull the FilterBox component into it's own file in order to export it for testing.

Before:
before

After:
after

Related issues: #5269, #5043, #4421, #3015, #5534

@codecov-io
Copy link

codecov-io commented Aug 17, 2018

Codecov Report

Merging #5664 into master will increase coverage by 0.52%.
The diff coverage is 69.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5664      +/-   ##
==========================================
+ Coverage   63.49%   64.02%   +0.52%     
==========================================
  Files         360      361       +1     
  Lines       22889    22940      +51     
  Branches     2549     2557       +8     
==========================================
+ Hits        14534    14687     +153     
+ Misses       8340     8238     -102     
  Partials       15       15
Impacted Files Coverage Δ
...ssets/src/visualizations/filter_box/filter_box.jsx 0% <0%> (ø)
superset/connectors/druid/models.py 83.65% <100%> (+1.09%) ⬆️
superset/views/core.py 74.12% <100%> (+0.19%) ⬆️
superset/connectors/base/models.py 91.5% <100%> (ø) ⬆️
superset/config.py 92.64% <100%> (+0.05%) ⬆️
superset/connectors/sqla/models.py 78.94% <52.17%> (+0.28%) ⬆️
...assets/src/visualizations/filter_box/FilterBox.jsx 77.95% <97.67%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a4b70d...e5ef6a8. Read the comment docs.

@mistercrunch
Copy link
Member

Sorry that this PR got ignored so far. It's great work but as you know there's ongoing work in redesigning filters as dashboard native components and if we want to deprecate filter box, we may want (but not necessarily have to) to keep it as simple as possible.

@xtinec (working on filters)

@emlittleworth
Copy link
Contributor Author

Yeah I definitely understand we probably don't want to introduce new functionality at the moment. I'll close this for now. @xtinec let me know if you want to chat about how it works if you decide to integrate cascading filter options!

@xtinec
Copy link
Contributor

xtinec commented Sep 12, 2018

@emlittleworth love to chat about cascading filter options and incorporate it into the new design!

@srggrs
Copy link
Contributor

srggrs commented Oct 24, 2018

@emlittleworth I'm interested to chat about it as well. How can we get in touch?

@ajones620
Copy link

@emlittleworth i'm also interested as well! are there any updates or is there any feedback i can contribute?

@jnthnvctr
Copy link

@xtinec and @emlittleworth - is this something that's still in progress?

@smic-datalabs-von
Copy link

Chiming in: Would definitely love this feature to be put up in Superset.

@t0nydean
Copy link

t0nydean commented Jun 8, 2020

@emlittleworth or @xtinec or @mistercrunch Did this feature or something similar ever get finished?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants