Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[migrations] Cleaning up migration logic #5167

Merged
merged 1 commit into from
Jun 12, 2018

Conversation

john-bodley
Copy link
Member

This PR removes duplicate logic (which is originally defined on lines 49-50). It seems like this was added twice in two separate PRs to resolve a prior issue.

to: @graceguo-supercat @michellethomas @mistercrunch @timifasubaa

@codecov-io
Copy link

codecov-io commented Jun 9, 2018

Codecov Report

Merging #5167 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5167   +/-   ##
=======================================
  Coverage   77.47%   77.47%           
=======================================
  Files          44       44           
  Lines        8741     8741           
=======================================
  Hits         6772     6772           
  Misses       1969     1969

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 915e6e9...fead61b. Read the comment docs.

@hughhhh
Copy link
Member

hughhhh commented Jun 10, 2018

🚢

@john-bodley john-bodley merged commit 502b617 into apache:master Jun 12, 2018
@john-bodley john-bodley deleted the john-bodley-migration-fix branch June 12, 2018 19:10
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants