-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cron picker to AlertReportModal #12032
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12032 +/- ##
==========================================
- Coverage 57.99% 53.17% -4.82%
==========================================
Files 907 438 -469
Lines 44719 15715 -29004
Branches 4056 4060 +4
==========================================
- Hits 25934 8357 -17577
+ Misses 18785 7358 -11427
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
86f5b73
to
c318e3a
Compare
4cdeab4
to
4769b4c
Compare
28974f9
to
b619e66
Compare
2792c5c
to
65ad542
Compare
65ad542
to
b96957b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled this branch and tried this out. LGTM
SUMMARY
src/common/components
react-js-cron
to the AlertReportModalreact-js-cron
example usage with a free-form input.crontab_humanized
api field to reports api (uses cron-descriptor python lib)BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
Humanized "Schedule" column
TEST PLAN
ADDITIONAL INFORMATION