-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Global nav menus open on hover #12025
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12025 +/- ##
==========================================
+ Coverage 66.58% 67.72% +1.13%
==========================================
Files 951 951
Lines 46663 46675 +12
Branches 4571 4571
==========================================
+ Hits 31070 31609 +539
+ Misses 15456 14953 -503
+ Partials 137 113 -24
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@rusackas I'm finding a case where hovering to show menu might have become an inconvenience: showing-menu-on-hover.mp4When saving chart, I wanted to click on the "Save" button, but if I move the mouse too fast, it will trigger open the hover menu and when I moved back to the position of the "Save" button and click, I would accidentally click on the menu and lost all my changes to the chart---which is quite annoying. I'm wondering if we can:
to avoid users accidentally clicking on the hovered menu item. We can do one or all of these if they make sense to you. |
@ktmud |
SUMMARY
I was fiddling around on the menus in this PR: #12024
I was finding it strangely tedious to have to click the global nav menus to open them. Hover-opening seemed lie it'd be more natural. Not sure others will agree, but if they do, we can merge this PR after that one.
Curious what others think, e.g. @junlincc @ktmud @mihir174
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION