Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: restored page on roles in security, executed other touchups, and… #11978

Merged
merged 13 commits into from
Dec 13, 2020

Conversation

srinify
Copy link
Contributor

@srinify srinify commented Dec 9, 2020

… renamed docs readme.txt to readme.md

SUMMARY

Main change was restoring & tidying up the Roles / Security page.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2020-12-09 at 9 46 23 AM

TEST PLAN

Fire up docs:

  • cd docs/
  • npm install
  • npm run start
  • navigate to localhost:8000`

  • Test /docs/security page

ADDITIONAL INFORMATION

No change to Superset (just docs!)

@codecov-io
Copy link

codecov-io commented Dec 9, 2020

Codecov Report

Merging #11978 (6340f8a) into master (9256b6f) will decrease coverage by 3.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11978      +/-   ##
==========================================
- Coverage   63.59%   60.37%   -3.23%     
==========================================
  Files         940      906      -34     
  Lines       45575    44641     -934     
  Branches     4373     4038     -335     
==========================================
- Hits        28984    26951    -2033     
- Misses      16415    17690    +1275     
+ Partials      176        0     -176     
Flag Coverage Δ
cypress 53.20% <ø> (?)
javascript ?
python 64.23% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/security/manager.py 90.41% <ø> (-0.60%) ⬇️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...ontend/src/dashboard/util/getDashboardFilterKey.ts 14.28% <0.00%> (-85.72%) ⬇️
...end/src/SqlLab/components/ExploreResultsButton.jsx 8.00% <0.00%> (-84.00%) ⬇️
...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx 14.70% <0.00%> (-82.97%) ⬇️
... and 442 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9256b6f...6340f8a. Read the comment docs.

@dpgaspar dpgaspar changed the title Restored docs page on roles in security, executed other touchups, and… docs: restored page on roles in security, executed other touchups, and… Dec 9, 2020
@ktmud ktmud linked an issue Dec 9, 2020 that may be closed by this pull request
@betodealmeida betodealmeida merged commit 3e22668 into apache:master Dec 13, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Security docs in the new docs site
5 participants