feat: add modal to import dashboards #11924
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11924 +/- ##
=======================================
Coverage 67.69% 67.70%
=======================================
Files 940 941 +1
Lines 45586 45658 +72
Branches 4378 4388 +10
=======================================
+ Hits 30861 30911 +50
- Misses 14622 14644 +22
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| * under the License. | ||
| */ | ||
| import React from 'react'; | ||
| import thunk from 'redux-thunk'; |
There was a problem hiding this comment.
I'll remove in #11936
| } | ||
|
|
||
| importResource(uploadFile, passwords).then(result => { | ||
| if (result) { |
There was a problem hiding this comment.
small nit, but you could also check the passwordFields state here, right, instead of returning it in the result?
There was a problem hiding this comment.
Actually no, if there's a validation error other than password needed the importResource will
- show a danger toast
- not set
passwordFields - return
false
So having an empty passwordFields does not guarantee success. This is because there's 3 states:
- Upload OK (returns
trueandpasswordFieldsis empty) - File validated but needs password (returns
falseandpasswordFieldsis set) - Validation failed in other ways (returns
falseandpasswordFieldsis empty)
| </div> | ||
| <input | ||
| name={`password-${fileName}`} | ||
| autoComplete="off" |
There was a problem hiding this comment.
this may not work for Chrome. You may want to try something like autoComplete="new-password"
There was a problem hiding this comment.
Cool, #TIL. I'll fix it in #11936
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| export type DashboardObject = { |
There was a problem hiding this comment.
just as an fyi, there are also some types in src/types. We may want to move everything there eventually.
There was a problem hiding this comment.
Yeah, I feel we should have a way of automatically generating these and schema.py from a single source of truth.
betodealmeida
force-pushed
the
PISQL-2
branch
from
b934e6e to
990ca8a
Compare
betodealmeida
force-pushed
the
PISQL-31
branch
from
fc34750 to
b2fee54
Compare
betodealmeida
force-pushed
the
PISQL-31
branch
from
b2fee54 to
89bbdcf
Compare
mistercrunch
added
🏷️ bot
SUMMARY
Identical to https://github.com/apache/incubator-superset/pull/11923/files, but for charts.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Tested importing dashboard to an existing database/chart, as well as a dashboard to a new database, works as expected.
Also added tests.
ADDITIONAL INFORMATION