-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: filters for alerts and reports list view #11900
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11900 +/- ##
==========================================
- Coverage 63.78% 63.59% -0.20%
==========================================
Files 927 462 -465
Lines 45006 28433 -16573
Branches 4308 0 -4308
==========================================
- Hits 28708 18082 -10626
+ Misses 16120 10351 -5769
+ Partials 178 0 -178
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
'created_by', | ||
createErrorHandler(errMsg => | ||
t( | ||
'An error occurred while fetching dataset datasource values: %s', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'An error occurred while fetching dataset datasource values: %s', | |
'An error occurred while fetching created by values: %s', |
Header: t('Created By'), | ||
id: 'created_by', | ||
input: 'select', | ||
operator: 'rel_o_m', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add these to an enum a recently (https://github.com/apache/incubator-superset/blob/1842c56209131757f47bf7706a601aa933c6da4b/superset-frontend/src/components/ListView/types.ts#L103) can we use that as we do in QueryList
which should make their meaning a little less ambiguous.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION