feat: Sqllab to Explore UX improvements api changes #11836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11836 +/- ##
==========================================
+ Coverage 66.52% 67.56% +1.03%
==========================================
Files 916 916
Lines 44545 44554 +9
Branches 4227 4227
==========================================
+ Hits 29634 30101 +467
+ Misses 14781 14350 -431
+ Partials 130 103 -27
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Nov 30, 2020
| @@ -284,6 +289,11 @@ def put(self, pk: int) -> Response: | |||
| 500: | |||
| $ref: '#/components/responses/500' | |||
| """ | |||
| override_columns = ( | |||
| bool(strtobool(request.args["override_columns"])) | |||
There was a problem hiding this comment.
It makes me angry that strtobool returns an integer. 😠
| - in: path | ||
| schema: | ||
| type: bool | ||
| name: override_column |
| dataset = DatasetDAO.update( | ||
| model=self._model, | ||
| properties=self._properties, | ||
| commit=True, |
There was a problem hiding this comment.
This change threw me off because commit already defaults to True.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Breaking down #11755 to have the api change separately get checked in.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
tox -e py38-sqlite -vv -- tests/datasets/api_tests.py::TestDatasetApi::test_update_dataset_item_w_override_columnsADDITIONAL INFORMATION