Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(release): small fixes and deprecate apache docs #11827

Merged
merged 2 commits into from
Nov 26, 2020

Conversation

dpgaspar
Copy link
Member

SUMMARY

Deprecate the step to update and push old docs to Apache. Also a couple of small doc fixes

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, LGTM

```

The script will output the exported variables. Here's example for 0.37.0rc1:

```
Set Release env variables
SUPERSET_VERSION=0.37.0
SUPERSET_VERSION=0.38.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text on line 83 should probably also be updated (it's referencing 0.38.0rc1).

@codecov-io
Copy link

codecov-io commented Nov 26, 2020

Codecov Report

Merging #11827 (dbc0e09) into master (bac84a3) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11827      +/-   ##
==========================================
- Coverage   67.56%   67.43%   -0.14%     
==========================================
  Files         916      916              
  Lines       44545    44545              
  Branches     4227     4227              
==========================================
- Hits        30098    30039      -59     
- Misses      14344    14399      +55     
- Partials      103      107       +4     
Flag Coverage Δ
cypress 54.60% <ø> (-0.65%) ⬇️
javascript 62.92% <ø> (ø)
python 64.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/SqlLab/reducers/getInitialState.js 33.33% <0.00%> (-16.67%) ⬇️
superset-frontend/src/reduxUtils.ts 70.88% <0.00%> (-8.87%) ⬇️
...rontend/src/SqlLab/components/TabbedSqlEditors.jsx 76.12% <0.00%> (-5.17%) ⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js 60.25% <0.00%> (-4.28%) ⬇️
...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx 49.01% <0.00%> (-3.93%) ⬇️
superset-frontend/src/SqlLab/reducers/sqlLab.js 37.60% <0.00%> (-3.31%) ⬇️
...end/src/SqlLab/components/TemplateParamsEditor.jsx 86.48% <0.00%> (-2.71%) ⬇️
...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx 81.81% <0.00%> (-1.82%) ⬇️
...set-frontend/src/dashboard/util/getDropPosition.js 92.06% <0.00%> (-1.59%) ⬇️
...rontend/src/SqlLab/components/AceEditorWrapper.tsx 59.49% <0.00%> (-1.27%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bac84a3...dbc0e09. Read the comment docs.

@dpgaspar dpgaspar merged commit 3578410 into apache:master Nov 26, 2020
@dpgaspar dpgaspar deleted the docs/releasing-gh-release branch November 26, 2020 11:50
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants