-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(release): small fixes and deprecate apache docs #11827
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, LGTM
``` | ||
|
||
The script will output the exported variables. Here's example for 0.37.0rc1: | ||
|
||
``` | ||
Set Release env variables | ||
SUPERSET_VERSION=0.37.0 | ||
SUPERSET_VERSION=0.38.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text on line 83 should probably also be updated (it's referencing 0.38.0rc1).
Codecov Report
@@ Coverage Diff @@
## master #11827 +/- ##
==========================================
- Coverage 67.56% 67.43% -0.14%
==========================================
Files 916 916
Lines 44545 44545
Branches 4227 4227
==========================================
- Hits 30098 30039 -59
- Misses 14344 14399 +55
- Partials 103 107 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
Deprecate the step to update and push old docs to Apache. Also a couple of small doc fixes
ADDITIONAL INFORMATION