chore(home-screen): fixes for loading states, flicker issue, and reduction of api calls

[pkdotson]

SUMMARY

This Pr is a follow up for community suggestions for home page adding loading states, css updates and reduction of three api calls that are originally called in a batch call on page load.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Updating units tests

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[ktmud]

Thanks for the fixes! Does this also fix the issue with the Recents tabs where the list will continue to grow if you switch tabs back and forth?

[pkdotson]

Thanks for the fixes! Does this also fix the issue with the Recents tabs where the list will continue to grow if you switch tabs back and forth?

Yes! It does. There was a issue with the key

[suddjian]

Fixes #11588

[codecov-io]

Codecov Report

Merging #11557 (35fe1cc) into master (091432e) will decrease coverage by 4.61%.
The diff coverage is 62.23%.

@@            Coverage Diff             @@
##           master   #11557      +/-   ##
==========================================
- Coverage   66.59%   61.97%   -4.62%     
==========================================
  Files         876      878       +2     
  Lines       42146    42311     +165     
  Branches     3943     3968      +25     
==========================================
- Hits        28066    26224    -1842     
- Misses      13977    15906    +1929     
- Partials      103      181      +78     

Flag	Coverage Δ
cypress	?
javascript	62.61% <62.23%> (+0.04%)	⬆️
python	61.59% <ø> (-0.56%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ontend/src/components/ListViewCard/ImageLoader.tsx	86.36% <ø> (ø)
...set-frontend/src/components/ListViewCard/index.tsx	94.23% <ø> (-5.77%)	⬇️
...rontend/src/views/CRUD/dashboard/DashboardList.tsx	73.68% <ø> (-5.27%)	⬇️
superset-frontend/src/views/CRUD/utils.tsx	48.78% <27.27%> (+0.54%)	⬆️
...perset-frontend/src/views/CRUD/chart/ChartCard.tsx	72.22% <44.44%> (-18.11%)	⬇️
...rontend/src/views/CRUD/dashboard/DashboardCard.tsx	72.97% <44.44%> (-20.78%)	⬇️
superset-frontend/src/views/CRUD/hooks.ts	56.64% <50.00%> (-7.39%)	⬇️
...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx	59.30% <58.33%> (-3.86%)	⬇️
...set-frontend/src/views/CRUD/welcome/EmptyState.tsx	87.80% <66.66%> (+0.30%)	⬆️
...-frontend/src/views/CRUD/welcome/ActivityTable.tsx	65.51% <68.75%> (+19.03%)	⬆️
... and 213 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 091432e...35fe1cc. Read the comment docs.

[rusackas]

Looks like lots of improvements! There might be some minor syntactical nits, but I think we should merge as is... this makes things much better!

[Kamh1234566]

Khalidhaqwi8@gmail.com