-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(explore): update the order of datasource dropdown menu #11424
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11424 +/- ##
=======================================
Coverage 62.30% 62.31%
=======================================
Files 861 861
Lines 40918 40918
Branches 3694 3694
=======================================
+ Hits 25494 25497 +3
+ Misses 15244 15241 -3
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please format your PR title to match: ^(build|chore|ci|docs|feat|fix|perf|refactor|style|test|other)((.+))?:\s.+
!
Looks good to me! Just a heads up, @hughhhh, in the last Superset meetup there was a request to add more context to PRs, specially why things are being changed, instead of just what. Would be nice to update the description to explain why you're making this change. |
@betodealmeida updated the description! thanks beto |
…into hugh/so-1118
During our internal discussions related to #11478, someone mentioned we should probably not make ”Edit Datasource" so accessible because users can easily accidentally update other people's datasource and break their charts. |
SUMMARY
As an Explore user, I want to see an intuitive menu for editing and updating my datasource, so that I can quickly and easily make the changes needed. So we updated overflow menu order in explore view order to edit, change, view
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION