Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explore): update the order of datasource dropdown menu #11424

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Oct 26, 2020

SUMMARY

As an Explore user, I want to see an intuitive menu for editing and updating my datasource, so that I can quickly and easily make the changes needed. So we updated overflow menu order in explore view order to edit, change, view

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2020-10-26 at 9 23 36 AM

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh changed the title change ordering of btn menu fix: Update Dataset Overflow Menu Oct 26, 2020
@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #11424 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11424   +/-   ##
=======================================
  Coverage   62.30%   62.31%           
=======================================
  Files         861      861           
  Lines       40918    40918           
  Branches     3694     3694           
=======================================
+ Hits        25494    25497    +3     
+ Misses      15244    15241    -3     
  Partials      180      180           
Flag Coverage Δ
#javascript 62.90% <100.00%> (ø)
#python 61.96% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../explore/components/controls/DatasourceControl.jsx 54.83% <100.00%> (ø)
superset/db_engine_specs/presto.py 82.07% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 894ca3c...2f8d77a. Read the comment docs.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format your PR title to match: ^(build|chore|ci|docs|feat|fix|perf|refactor|style|test|other)((.+))?:\s.+!

@github-actions github-actions bot dismissed their stale review October 26, 2020 15:22

All good!

@hughhhh hughhhh requested a review from betodealmeida October 26, 2020 16:58
@betodealmeida
Copy link
Member

Looks good to me! Just a heads up, @hughhhh, in the last Superset meetup there was a request to add more context to PRs, specially why things are being changed, instead of just what. Would be nice to update the description to explain why you're making this change.

@hughhhh
Copy link
Member Author

hughhhh commented Oct 26, 2020

@betodealmeida updated the description! thanks beto

@hughhhh hughhhh closed this Oct 27, 2020
@hughhhh hughhhh reopened this Oct 27, 2020
@ktmud ktmud changed the title fix: Update Dataset Overflow Menu feat(explore): update the order of datasource dropdown menu Oct 27, 2020
@hughhhh hughhhh merged commit fd8f4e9 into master Oct 27, 2020
@hughhhh hughhhh deleted the hugh/so-1118 branch October 27, 2020 03:44
@ktmud
Copy link
Member

ktmud commented Oct 29, 2020

During our internal discussions related to #11478, someone mentioned we should probably not make ”Edit Datasource" so accessible because users can easily accidentally update other people's datasource and break their charts.

auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants