docs: add note about migration in #11098 to Changelog #11256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11256 +/- ##
==========================================
- Coverage 65.58% 61.47% -4.12%
==========================================
Files 832 831 -1
Lines 39448 39515 +67
Branches 3598 3598
==========================================
- Hits 25873 24290 -1583
- Misses 13466 15043 +1577
- Partials 109 182 +73
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mistercrunch
approved these changes
Oct 14, 2020
UPDATING.md
Outdated
| @@ -25,6 +25,8 @@ assists people when migrating to a new version. | |||
|
|
|||
| * [11244](https://github.com/apache/incubator-superset/pull/11244): The `REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD` feature flag has been removed after being set to True for multiple months. | |||
|
|
|||
| * [11098](https://github.com/apache/incubator-superset/pull/11098): includes a database migration that adds a column caled `uuid` to all models, and updates the `Dashboard.position_json` column to also have UUIDs of charts. Depending on the number of objects the migration might take up to 3-4 minutes, requiring planning for the downtime. | |||
There was a problem hiding this comment.
NIT: "to all models" -> "to some models" (?)
There was a problem hiding this comment.
nit: I'm no native speaker, but the two "the"'s in the last sentence (the number of objects, the downtime) seems not necessary?
Better description Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
No need to apologize, it's much better. I also noticed I had a typo in "called", I wrote "caled". :-P |
betodealmeida
changed the title
ktmud
approved these changes
Oct 14, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
…1256) * Add note about apache#11098 * Update UPDATING.md Better description Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add entry to
UPDATING.mdabout the DB migration in #11098.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
N/A
ADDITIONAL INFORMATION