Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop coveralls code-coverage flow? #1162

Closed
rzo1 opened this issue Mar 27, 2024 · 3 comments
Closed

Drop coveralls code-coverage flow? #1162

rzo1 opened this issue Mar 27, 2024 · 3 comments
Milestone

Comments

@rzo1
Copy link
Contributor

rzo1 commented Mar 27, 2024

Can we drop the coveralls github action?

I did a quick search at ASF level and I think, that only datasketches-cpp is using it. So might be good to just drop it and rely on other test coverage report metrics, which are more common at ASF level.

@lewismc
Copy link
Member

lewismc commented Mar 27, 2024

SonarCloud.io is very good.

@sigee
Copy link
Contributor

sigee commented Aug 28, 2024

Hi,
For checking and requiring a minimum test coverage you could use jacoco as it is used in apache commons project.

There is no generated badge for readme, but the pipeline could work perfectly by require a minimum coverage for different metrics (line coverage, branch coverage, class coverage, etc.).
Jacoco is already part of this project, so only the configuration is needed here.

What do you think?

@rzo1
Copy link
Contributor Author

rzo1 commented Aug 28, 2024

I am using Jacoco in most of my projects ;-) - I have no objections in replacing it.

@jnioche jnioche added this to the 3.1.0 milestone Sep 5, 2024
@jnioche jnioche closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants