-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Relax Visual Studio version constraint in the specialization of dmlc::type_name_helper<DT>
for DT=mxnet::Tuple<T>
#15144
Conversation
Thanks for your contributions @Vigilans |
Please add "Fixes #14116" in the PR description to automatically close the issue when the PR is merged |
@Vigilans could you trigger the CI again? thanks! |
Sync with upstream
@Vigilans Could you please look into CI failure? @anirudh2290 @eric-haibin-lin Could you please review this PR? Thanks! |
Sync with upstream
@karan6181 Now all CI checks have been passed...seems to be the problem of syncing with master. |
@anirudh2290 Can you review this PR.? |
I approve this PR, see #15632. |
@QueensGambit Thanks for reviewing. You can actually use the official approve GitHub approve button under Files Changed -> Review Changes -> Approve even if you are not a committer. @anirudh2290 @junrushao1994 @eric-haibin-lin Can any of you help review this PR? |
Relax Visual Studio version constraint in the specialization of `dmlc::type_name_helper<DT>` for `DT=mxnet::Tuple<T>`
Relax Visual Studio version constraint in the specialization of `dmlc::type_name_helper<DT>` for `DT=mxnet::Tuple<T>`
Description
Fix #14116, Fix #15143
Description of the content is covered in #15143.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes