Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Investigate and fix zip_safe=False in PEX #3558

Closed
Code0x58 opened this issue Jul 7, 2020 · 1 comment
Closed

Investigate and fix zip_safe=False in PEX #3558

Code0x58 opened this issue Jul 7, 2020 · 1 comment

Comments

@Code0x58
Copy link
Contributor

Code0x58 commented Jul 7, 2020

While upgrading from python2 to python3, the generated PEXs would not work due to being unable to import from at least pex_library includes, related to the introduction of PEP-420, but for some reason wasn't working with the default zip_safe=None/zip_safe=True, so the workaround was to cause the PEXs to always be extracted to disk rather than loaded straight into memory.
@Code0x58 Code0x58 mentioned this issue Jul 7, 2020
Merged
@joshfischer1108
Copy link
Member

It looks like this issue was resolved with #3522 . Closing for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshfischer1108 @Code0x58