Arrow: add support for null vectors #10953
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix NullPointerException when trying to add the vector's class name to the message for an UnsupportedOperationException
This test more closely follows the reproduction steps described in issue apache#10275
…eaderTest.java Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
…eaderTest.java Co-authored-by: Eduard Tudenhoefner <etudenhoefner@gmail.com>
This solution hacks in a VectorHolder instance built specifically for the missing column. Implementing this hack allowed me to explore what would be needed to support vectorized reading of null columns
nastra
reviewed
Aug 22, 2024
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/GenericArrowVectorAccessorFactory.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Aug 22, 2024
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/GenericArrowVectorAccessorFactory.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Aug 22, 2024
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/GenericArrowVectorAccessorFactory.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Aug 22, 2024
There was a problem hiding this comment.
@sl255051 I spent some time understanding the problem and going through the code and fixing it myself (without first looking at this PR). I think you're on the right track here to handle the root cause and we should have a NullAccessor that internally tracks a NullVector.
I would suggest to squash all the commits to a single one and then go through my comments
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
Outdated
Show resolved
Hide resolved
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java
Outdated
Show resolved
Hide resolved
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
Outdated
Show resolved
Hide resolved
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedReaderBuilder.java
Show resolved
Hide resolved
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/apache/iceberg/arrow/vectorized/GenericArrowVectorAccessorFactoryTest.java
Outdated
Show resolved
Hide resolved
|
Thank you, @nastra, for your help. I will be on vacation next week. I will pick this up again when I return on September 3.
|
nastra
changed the title
Update unit test to write a row after the schema has been altered. The test will then verify that all rows written both before and after the schema change can be correctly read.
nastra
reviewed
Sep 18, 2024
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Sep 18, 2024
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java
Outdated
Show resolved
Hide resolved
Adding a second row was creating test complexity. The order in which the two rows are read asynchronously was creating randomness thus making it hard to predict the expected values. I'm not sure adding a second row of data was really adding any benefit anyway.
Those two test helper methods are highly tuned for a specific schema, a schema that does not exist in this test.
|
@amogh-jahagirdar This PR is ready for your review |
slessard
commented
Sep 24, 2024
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
Outdated
Show resolved
Hide resolved
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java
Outdated
Show resolved
Hide resolved
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java
Outdated
Show resolved
Hide resolved
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java
Outdated
Show resolved
Hide resolved
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java
Outdated
Show resolved
Hide resolved
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java
Outdated
Show resolved
Hide resolved
These unit tests, particularly `testIsDummy1` and `testIsDummy2`, exposed a bug in the code where the `isDummy` method no longer returned the expected value.
nastra
reviewed
Sep 26, 2024
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Sep 26, 2024
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Sep 26, 2024
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Sep 26, 2024
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/VectorHolderTest.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Sep 26, 2024
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/VectorHolderTest.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Sep 26, 2024
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/VectorHolderTest.java
Outdated
Show resolved
Hide resolved
|
@amogh-jahagirdar I am not planning to make any additional changes. Please review |
nastra
reviewed
Sep 27, 2024
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new class NullAccessor to aid reading null columns. A null column is a column that exists in the Iceberg schema, but does not exist in the parquet schema. A column would exist in Iceberg, but not in Parquet when a column is added to the Iceberg schema, but no new rows have been added to the table. See ArrowReadetTest.testReadColumnThatDoesNotExistInParquetSchema for an example.