Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-18069] [scala, docs] Scaladocs 2.12 fails to recognize inner interfaces #12443

Closed
wants to merge 1 commit into from

Conversation

tzulitai
Copy link
Contributor

@tzulitai tzulitai commented Jun 2, 2020

This is a similar issue as reported here: scala/bug#10509.

This seems to be a problem with Scaladocs 2.12.x. The only workaround, it seems from the issue reports, is to redundantly add the full-length qualifiers for such interfaces.

Verifying this change

Verified this by doing the following steps

  • Build the project: mvn clean install -DskipTests
  • Build the Javadocs: mvn javadoc:aggregate -Paggregate-scaladoc
  • Build the Scaladocs: cd flink-scala/ && mvn scala:doc

…nterfaces

This is a similar issue as reported here:
scala/bug#10509.

This seems to be a problem with Scala 2.12.x. The only workaround is to
redundantly add the full-length qualifiers for such interfaces.
@flinkbot
Copy link
Collaborator

flinkbot commented Jun 2, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit bab66f0 (Tue Jun 02 12:41:50 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 2, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@rmetzger rmetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to merge

@tzulitai
Copy link
Contributor Author

tzulitai commented Jun 4, 2020

Thanks, merging ...

@zentol zentol closed this Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants