Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] MarkArea not fully fixed in version 5.4.2 #18499

Open
ily-salamat opened this issue Apr 12, 2023 · 5 comments
Open

[Bug] MarkArea not fully fixed in version 5.4.2 #18499

ily-salamat opened this issue Apr 12, 2023 · 5 comments
Labels
Milestone

Comments

@ily-salamat
Copy link

Version

5.4.2

Link to Minimal Reproduction

https://codepen.io/ily-salamat/pen/bGmVjGj

Steps to Reproduce

I already opened this issue here #18130 and it's fixed in this PR #18229 and apparently it's not fully fixed because now there is a gap issue between bars and mark area

In 5.4.0 version works fine
See example: https://codepen.io/ily-salamat/pen/LYBZzNo

Now in 5.4.2 there is a gap issue
See example: https://codepen.io/ily-salamat/pen/bGmVjGj

Current Behavior

Since version 5.4.2 there is a gap between bars and mark area

Expected Behavior

MarkArea should works properly as in the previous version

Environment

- OS:
- Browser:
- Framework:

Any additional comments?

No response

@echarts-bot echarts-bot bot added en This issue is in English pending We are not sure about whether this is a bug/new feature. labels Apr 12, 2023
@helgasoft
Copy link

@ily-salamat, just adding a simplified update of your demo.
Unwanted markArea overlaps show as darker red stripes on auto-expanding zoom.

image

@ozkoidi
Copy link

ozkoidi commented Jul 11, 2023

It's been 3 months since the last comment. Any news on this? This is a regression (see #18130) and it should be fixed. The current status blocks us from using the latest versions

@plainheart plainheart added topic: bar topic: marker and removed pending We are not sure about whether this is a bug/new feature. labels Jul 12, 2023
@plainheart plainheart added this to the 5.5.0 milestone Jul 12, 2023
@plainheart
Copy link
Member

plainheart commented Jul 12, 2023

@ozkoidi Apologies for this blocker. I've confirmed it is a bug that wasn't fixed by #18229 and will fix it soon.

@plainheart
Copy link
Member

@ozkoidi After a simple dig, I think it's not a "bug" in this case. #17098 & #18229 (#18229 (comment)) make the markArea include the whole category, instead of starting from and ending at the center of the bar. It's the reason why the mark areas overlap. If the previous behavior is expected to be reserved, a new option (like markOrigin?) might be needed.

BTW, there seems to be another potential bug when the axisTick.alignWithLabel is set as true. See this demo for reproduction.

cc: @Ovilia @jiawulin001

@Chewieez
Copy link

Chewieez commented Aug 16, 2023

I am also seeing the bug that @plainheart referred to at the end of their comment with axisTick.alignWithLabel in 5.4.3.

I was able to work around it by attaching my markArea to a 2nd xAxis that has axisTick.alignWithLabel = false, while my first xAxis has it set to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants