Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ftr:about Graceful Offline #239

Closed
pantianying opened this issue Oct 22, 2019 · 1 comment
Closed

Ftr:about Graceful Offline #239

pantianying opened this issue Oct 22, 2019 · 1 comment

Comments

@pantianying
Copy link
Member

pantianying commented Oct 22, 2019 •
edited
Loading

What would you like to be added:
Problems encountered:

When the provider end does not get offline gracefully and does not receive the message with eventType of delete, the client will always keep the IP of the provider.

Solutions

  1. The client should have the mechanism of kicking out the wrong IP: the client invoke should kick out the timeout IP, or reduce the priority of the timeout IP. Under the current code, the client can not remove the problematic IP. Even if you have a retry mechanism, now you have to wait for a timeout every time to retry. This is unacceptable.

  2. Retry selection: all errors cannot be retried. Business exceptions should not be retried.
    Why is this needed:
@flycash flycash mentioned this issue Nov 15, 2019
Merged
@hxmhlt
Copy link
Contributor

hxmhlt commented Dec 22, 2019

The issue is resloved.So I will close it.

@hxmhlt hxmhlt closed this as completed Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hxmhlt @pantianying