From 880d3cd23bac3210c297ad0fd7ca56167c0d67e4 Mon Sep 17 00:00:00 2001
From: Luwei <814383175@qq.com>
Date: Wed, 20 Dec 2023 21:31:07 +0800
Subject: [PATCH] [Fix] (schema change) forbid adding time type column

---
 .../doris/alter/SchemaChangeHandler.java      |  4 ++
 .../schema_change_p0/check_time_type.groovy   | 55 +++++++++++++++++++
 2 files changed, 59 insertions(+)
 create mode 100644 regression-test/suites/schema_change_p0/check_time_type.groovy

diff --git a/fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java b/fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
index 336d361766b5c1..654775616b10e8 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
@@ -951,6 +951,10 @@ private boolean addColumnInternal(OlapTable olapTable, Column newColumn, ColumnP
             }
         }
 
+        if (newColumn.getType().isTime() || newColumn.getType().isTimeV2()) {
+            throw new DdlException("Time type is not supported for olap table");
+        }
+
         // hll must be used in agg_keys
         if (newColumn.getType().isHllType() && KeysType.AGG_KEYS != olapTable.getKeysType()) {
             throw new DdlException("HLL type column can only be in Aggregation data model table: " + newColName);
diff --git a/regression-test/suites/schema_change_p0/check_time_type.groovy b/regression-test/suites/schema_change_p0/check_time_type.groovy
new file mode 100644
index 00000000000000..e15a6fc711d4c2
--- /dev/null
+++ b/regression-test/suites/schema_change_p0/check_time_type.groovy
@@ -0,0 +1,55 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("check_time_type", "p0") {
+    def tableName = "check_time_type"
+
+    sql """
+        drop table IF exists ${tableName}
+    """
+
+    sql """
+        CREATE TABLE ${tableName}
+        (
+            k1 INT,
+            k2 int,
+            v1 INT,
+            v2 INT,
+            v3 varchar(32)
+        )
+        UNIQUE KEY (k1, k2)
+        DISTRIBUTED BY HASH(k2) BUCKETS 1
+        PROPERTIES (
+            'light_schema_change' = 'true',
+            'replication_num' = '1'
+        )
+    """
+
+    sql """
+        insert into ${tableName} values (1, 2, 3, 4, 'a');
+    """
+
+    test {
+        sql """ alter table ${tableName} add column new_col time """
+        exception "errCode = 2, detailMessage = Time type is not supported for olap table"
+    }
+
+    sql """
+        select * from ${tableName}
+    """
+}
+