From 6aeeb5de3f106439ff47d6cb82b855d354c5a23d Mon Sep 17 00:00:00 2001 From: liaoxin Date: Tue, 19 Jul 2022 10:41:44 +0800 Subject: [PATCH] [fix](cache) fix that ShardedLRUCache may coredump when destructor was called --- be/src/olap/lru_cache.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/be/src/olap/lru_cache.cpp b/be/src/olap/lru_cache.cpp index 146ab34c4ee607..b1834efac3a5b5 100644 --- a/be/src/olap/lru_cache.cpp +++ b/be/src/olap/lru_cache.cpp @@ -462,14 +462,14 @@ ShardedLRUCache::ShardedLRUCache(const std::string& name, size_t total_capacity, } ShardedLRUCache::~ShardedLRUCache() { + _entity->deregister_hook(_name); + DorisMetrics::instance()->metric_registry()->deregister_entity(_entity); if (_shards) { for (int s = 0; s < _num_shards; s++) { delete _shards[s]; } delete[] _shards; } - _entity->deregister_hook(_name); - DorisMetrics::instance()->metric_registry()->deregister_entity(_entity); } Cache::Handle* ShardedLRUCache::insert(const CacheKey& key, void* value, size_t charge,