Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: datafusion-cli can no longer run EXPLAIN ANALYZE #8690

Closed
alamb opened this issue Dec 30, 2023 · 2 comments · Fixed by #8717
Closed

Regression: datafusion-cli can no longer run EXPLAIN ANALYZE #8690

alamb opened this issue Dec 30, 2023 · 2 comments · Fixed by #8717
Labels
bug Something isn't working

Comments

@alamb
Copy link
Contributor

alamb commented Dec 30, 2023

Describe the bug

datafusion-cli can no longer run EXPLAIN ANALYZE

To Reproduce

datafusion-cli -c "explain analyze select * from './parquet-testing/data/data_index_bloom_encoding_stats.parquet';"
DataFusion CLI v34.0.0
Internal error: Optimization not supported for ANALYZE.
This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker

Expected behavior

I expect the query to run and produce an EXPLAIN plan annotated with output counters

Additional context

The code that makes the error appears to be https://github.com/apache/arrow-datafusion/blob/ba50a8b178eece7e79b100d0b73bdc9d6d3ec6d5/datafusion/physical-plan/src/analyze.rs#L119

I suspect this is only a datafusion-cli issue, and that it started happening after #8651 from @berkaysynnada (which now checks 'unbounded output')

@alamb alamb added the bug Something isn't working label Dec 30, 2023
@alamb alamb changed the title datafusion-cli can no longer run EXPLAIN ANALYZE Regression: datafusion-cli can no longer run EXPLAIN ANALYZE Dec 30, 2023
@berkaysynnada
Copy link
Contributor

Should we remove the panic in unbounded_output() and simply reflect its input plan's unboundedness in AnalyzeExec?

@alamb
Copy link
Contributor Author

alamb commented Dec 31, 2023

Should we remove the panic in unbounded_output() and simply reflect its input plan's unboundedness in AnalyzeExec?

Yes, I think that would be the best solution. I think returning Ok(false) is probably the easiest fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants