Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array_ndims doesn't correctly handle List(Null) #8318

Closed
jayzhan211 opened this issue Nov 25, 2023 · 0 comments · Fixed by #8320
Closed

array_ndims doesn't correctly handle List(Null) #8318

jayzhan211 opened this issue Nov 25, 2023 · 0 comments · Fixed by #8320
Labels
enhancement New feature or request

Comments

@jayzhan211
Copy link
Contributor

jayzhan211 commented Nov 25, 2023

Is your feature request related to a problem or challenge?

To reproduce error select array_ndims(arrow_cast([null], 'List(List(List(Int64)))'));

btw select array_ndims(make_array()) should be 1 instead.

Describe the solution you'd like

Compute ndims on DataType, this avoid downcast the actual ArrayRef and it is much more straightforward.

Describe alternatives you've considered

No response

Additional context

Done in #8317, plan to split it to another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant