Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change output ordering display of sources #8297

Closed
mustafasrepo opened this issue Nov 22, 2023 · 3 comments · Fixed by #8304
Closed

Change output ordering display of sources #8297

mustafasrepo opened this issue Nov 22, 2023 · 3 comments · Fixed by #8304
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mustafasrepo
Copy link
Contributor

Is your feature request related to a problem or challenge?

Current source executors(CsvExec, etc.) contains outpout_ordering inside display. For the following table

CREATE EXTERNAL TABLE multiple_ordered_table (
  a0 INTEGER,
  a INTEGER,
  b INTEGER,
  c INTEGER,
  d INTEGER
)
STORED AS CSV
WITH HEADER ROW
WITH ORDER (a ASC, b ASC)
WITH ORDER (c ASC)
LOCATION '../core/tests/data/window_2.csv';

display would be

----CsvExec: file_groups={1 group: [[path]]}, projection=[a, b], output_ordering=[a@0 ASC NULLS LAST, b@1 ASC NULLS LAST], has_header=true

It would be nice, if output ordering would contain all of the valid orderings at the source such as following

----CsvExec: file_groups={1 group: [[path]]}, projection=[a, b], output_orderings=[[a@0 ASC NULLS LAST, b@1 ASC NULLS LAST], [c@2 ASC NULLS LAST]], has_header=true

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@mustafasrepo mustafasrepo added enhancement New feature or request good first issue Good for newcomers labels Nov 22, 2023
@alamb
Copy link
Contributor

alamb commented Nov 22, 2023

I agree this would be a great first issue

I think the relevant code is https://github.com/apache/arrow-datafusion/blob/b46b7c0ea27e7c5ec63f5367ed04c9612a32d717/datafusion/core/src/datasource/physical_plan/mod.rs#L138-L142

@QuenKar
Copy link
Contributor

QuenKar commented Nov 22, 2023

hi, I am new here and curious about this.

@mustafasrepo
Copy link
Contributor Author

Thanks @QuenKar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants