Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to run sqllogictest under IDEs with integrated debuggers #8287

Closed
alamb opened this issue Nov 20, 2023 · 3 comments · Fixed by #8288
Closed

Make it easier to run sqllogictest under IDEs with integrated debuggers #8287

alamb opened this issue Nov 20, 2023 · 3 comments · Fixed by #8288
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Nov 20, 2023

Is your feature request related to a problem or challenge?

@tustvold mentioned to me that he can't debug sqllogictests using the debugger (I think he uses an IntelliJ derived one). I also can't do it under RustRover (also IntelliJ derived)

I believe that is because when you tell IntelliJ to run cargo test ... it sticks a bunch of extra flags on it:
A target defined as test --test sqllogictests

Results in cargo test being run like this:

/Users/alamb/.cargo/bin/cargo test --color=always --test sqllogictests --no-fail-fast -- --format=json -Z unstable-options --show-output

Describe the solution you'd like

I would like to be able to run sqllogictests as a bin target as well as a test target so that IDEs that make assumptions about what a test target does (aka what flags it accepts) can still be used

For example, I would like to run something like this (to run the metadata.slt test):

cargo run -p datafusion-sqllogictest  -- metadata

Describe alternatives you've considered

We could potentially make the sqllogictest runner mimic the rust test runner more directly (e.g. accept the same flags, etc)

Additional context

No response

@alamb alamb added the enhancement New feature or request label Nov 20, 2023
@alamb
Copy link
Contributor Author

alamb commented Nov 20, 2023

I am seriously considering simply making the sqllogictest tests actually rust tests (maybe with a 'regen' style script). Will give that a try and see how it works

@alamb
Copy link
Contributor Author

alamb commented Nov 20, 2023

Actually, the thing is I need to be able to pass in --complete somehow 🤔

@alamb
Copy link
Contributor Author

alamb commented Nov 20, 2023

Hmm, maybe if we just ported to using Clap faking the other options would be eaiser: #4769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant