-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sqllogictests doesn't cover cases if the column name is not expected. #6349
Comments
@melgenek I wonder if you have any thoughts on this idea? |
As far as I can tell, sqllogictest in general, and There are some ways to extend
On the other hand, one could make comparisons work on the Datafusion side. It seems that the Another way is to create a more powerful version of an
This way both specific Arrow types and names could be checked with one query. |
Thank you @melgenek -- this is excellent advice. We already have a version of this (though this also looks at the data) with the DESCRIBE dataframe method... Maybe we could connect it into SQL https://docs.rs/datafusion/latest/datafusion/dataframe/struct.DataFrame.html#method.describe |
Is your feature request related to a problem or challenge?
As we port our tests to sqllogictests #4460 it is important to retain test coverage
One thing that was noticed is that sqllogictest tests doesn't cover cases if the column name is not expected.
So for example, it will show the following outputs as the same
to
Describe the solution you'd like
It would be nice to have some way (perhaps optionally) that verified the column names as well
Describe alternatives you've considered
No response
Additional context
@comphead brought thus up on #6329 (review)
The text was updated successfully, but these errors were encountered: