Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error type in RecordBatchStream #4172

Closed
crepererum opened this issue Nov 11, 2022 · 1 comment
Closed

Error type in RecordBatchStream #4172

crepererum opened this issue Nov 11, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@crepererum
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
RecordBatchStream is a DataFusion type. However it carries an ArrowError instead of DataFusionError. This leads to some wild error wrapping like this one:

https://github.com/apache/arrow-datafusion/blob/5883e43db6c16d3ac3616302606849abbfbc86eb/datafusion/core/src/physical_plan/aggregates/row_hash.rs#L181

This makes it hard to detect the actual underlying error, e.g. ResourceExhausted for "out of memory" (also see #3941 where this would be useful).

Describe the solution you'd like
Make RecordBatchStream a DataFusionError instead. I'm aware this is a quite major change.

Describe alternatives you've considered
-

Additional context
-

@crepererum
Copy link
Contributor Author

Closed by #5101.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant