You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
In MemoryManager, can_grow_directly tries to grow memory attempt and blocks the thread when it cannot acquire for a least amount of memory (Condvar.wait). It looks a bit strange to wait forever for other consumers to spill there. Because it doesn't actually trigger other consumers to do spilling but just passively waits for notification once other consumers do spilling, in worse case it might wait for very long time. In such case, it seems more ideal to wait for a duration, and spill by itself if timeout happens.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
In
MemoryManager
,can_grow_directly
tries to grow memory attempt and blocks the thread when it cannot acquire for a least amount of memory (Condvar.wait
). It looks a bit strange to wait forever for other consumers to spill there. Because it doesn't actually trigger other consumers to do spilling but just passively waits for notification once other consumers do spilling, in worse case it might wait for very long time. In such case, it seems more ideal to wait for a duration, and spill by itself if timeout happens.Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: