Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to can_grow_directly #1920

Closed
viirya opened this issue Mar 4, 2022 · 0 comments
Closed

Add timeout to can_grow_directly #1920

viirya opened this issue Mar 4, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@viirya
Copy link
Member

viirya commented Mar 4, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

In MemoryManager, can_grow_directly tries to grow memory attempt and blocks the thread when it cannot acquire for a least amount of memory (Condvar.wait). It looks a bit strange to wait forever for other consumers to spill there. Because it doesn't actually trigger other consumers to do spilling but just passively waits for notification once other consumers do spilling, in worse case it might wait for very long time. In such case, it seems more ideal to wait for a duration, and spill by itself if timeout happens.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant