Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field Metadata Lost on CROSS JOIN #12734

Closed
Tracked by #12733
alamb opened this issue Oct 3, 2024 · 2 comments · Fixed by #12729
Closed
Tracked by #12733

Field Metadata Lost on CROSS JOIN #12734

alamb opened this issue Oct 3, 2024 · 2 comments · Fixed by #12729
Assignees

Comments

@alamb
Copy link
Contributor

alamb commented Oct 3, 2024

Describe the bug

During upgrade of DataFusion in InfluxDB @itsjunetime found that somewhere Field level metadata (aka Field::with_metadata is being lost during DataFusion logical planning

This manifests itself as an error during the physical planning

Internal Error: Physical input schema should be the same as the one converted from logical input schema

To Reproduce

Run this query in metadata.slt

# Regression test: missing schema metadata, when aggregate on cross join
query I
SELECT count("data"."id")
FROM
  (
   SELECT "id" FROM "table_with_metadata"
  ) as "data",
  (
    SELECT "id" FROM "table_with_metadata"
  ) as "samples";

Expected behavior

No error during physical planning

Additional context

@alamb
Copy link
Contributor Author

alamb commented Oct 3, 2024

I believe @wiedld plans to work on this

@wiedld
Copy link
Contributor

wiedld commented Oct 3, 2024

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants