diff --git a/ballista/rust/core/src/error.rs b/ballista/rust/core/src/error.rs index b2c8d99ae9f9..e9ffcd8180eb 100644 --- a/ballista/rust/core/src/error.rs +++ b/ballista/rust/core/src/error.rs @@ -139,7 +139,7 @@ impl From for BallistaError { } impl Display for BallistaError { - fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { + fn fmt(&self, f: &mut Formatter) -> std::fmt::Result { match self { BallistaError::NotImplemented(ref desc) => { write!(f, "Not implemented: {}", desc) diff --git a/datafusion-cli/src/print_format.rs b/datafusion-cli/src/print_format.rs index dadee4c7c844..e05d8bd074d1 100644 --- a/datafusion-cli/src/print_format.rs +++ b/datafusion-cli/src/print_format.rs @@ -60,7 +60,7 @@ impl FromStr for PrintFormat { } impl fmt::Display for PrintFormat { - fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { + fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { match *self { Self::Csv => write!(f, "csv"), Self::Tsv => write!(f, "tsv"), diff --git a/datafusion/src/datasource/object_store/mod.rs b/datafusion/src/datasource/object_store/mod.rs index aece82ac2cf2..77ca1ef6bae7 100644 --- a/datafusion/src/datasource/object_store/mod.rs +++ b/datafusion/src/datasource/object_store/mod.rs @@ -171,7 +171,7 @@ pub struct ObjectStoreRegistry { } impl fmt::Debug for ObjectStoreRegistry { - fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { + fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { f.debug_struct("ObjectStoreRegistry") .field( "schemes", diff --git a/datafusion/src/error.rs b/datafusion/src/error.rs index 0dccec9cdcc7..5e94e141688c 100644 --- a/datafusion/src/error.rs +++ b/datafusion/src/error.rs @@ -105,7 +105,7 @@ impl From for DataFusionError { } impl Display for DataFusionError { - fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { + fn fmt(&self, f: &mut Formatter) -> std::fmt::Result { match *self { DataFusionError::ArrowError(ref desc) => write!(f, "Arrow error: {}", desc), DataFusionError::ParquetError(ref desc) => { diff --git a/datafusion/src/execution/memory_manager.rs b/datafusion/src/execution/memory_manager.rs index 817ef828fe4b..caa597bea603 100644 --- a/datafusion/src/execution/memory_manager.rs +++ b/datafusion/src/execution/memory_manager.rs @@ -60,7 +60,7 @@ impl MemoryConsumerId { } impl Display for MemoryConsumerId { - fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result { + fn fmt(&self, f: &mut Formatter) -> fmt::Result { write!(f, "{}:{}", self.partition_id, self.id) } } @@ -123,7 +123,7 @@ pub trait MemoryConsumer: Send + Sync { } impl Debug for dyn MemoryConsumer { - fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result { + fn fmt(&self, f: &mut Formatter) -> fmt::Result { write!( f, "{}[{}]: {}", @@ -135,7 +135,7 @@ impl Debug for dyn MemoryConsumer { } impl Display for dyn MemoryConsumer { - fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result { + fn fmt(&self, f: &mut Formatter) -> fmt::Result { write!(f, "{}[{}]", self.name(), self.id(),) } } @@ -280,7 +280,7 @@ impl MemoryManager { } impl Display for MemoryManager { - fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result { + fn fmt(&self, f: &mut Formatter) -> fmt::Result { let requesters = self.requesters .lock() diff --git a/datafusion/src/execution/mod.rs b/datafusion/src/execution/mod.rs index 987b329f8418..ebc7c011970b 100644 --- a/datafusion/src/execution/mod.rs +++ b/datafusion/src/execution/mod.rs @@ -19,7 +19,7 @@ pub mod context; pub mod dataframe_impl; -pub mod disk_manager; -pub mod memory_manager; +pub(crate) mod disk_manager; +pub(crate) mod memory_manager; pub mod options; pub mod runtime_env; diff --git a/datafusion/src/execution/runtime_env.rs b/datafusion/src/execution/runtime_env.rs index 3356be15faf6..1e1aecd33c1d 100644 --- a/datafusion/src/execution/runtime_env.rs +++ b/datafusion/src/execution/runtime_env.rs @@ -36,7 +36,7 @@ pub struct RuntimeEnv { } impl Debug for RuntimeEnv { - fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { + fn fmt(&self, f: &mut Formatter) -> std::fmt::Result { write!(f, "RuntimeEnv") } } diff --git a/datafusion/src/logical_plan/dfschema.rs b/datafusion/src/logical_plan/dfschema.rs index 9db720eac587..7b6471f64dd7 100644 --- a/datafusion/src/logical_plan/dfschema.rs +++ b/datafusion/src/logical_plan/dfschema.rs @@ -389,7 +389,7 @@ impl ToDFSchema for Vec { } impl Display for DFSchema { - fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { + fn fmt(&self, f: &mut Formatter) -> std::fmt::Result { write!( f, "{}", diff --git a/datafusion/src/logical_plan/expr.rs b/datafusion/src/logical_plan/expr.rs index dadc16853074..00877dda48dc 100644 --- a/datafusion/src/logical_plan/expr.rs +++ b/datafusion/src/logical_plan/expr.rs @@ -169,7 +169,7 @@ impl FromStr for Column { } impl fmt::Display for Column { - fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { + fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { match &self.relation { Some(r) => write!(f, "#{}.{}", r, self.name), None => write!(f, "#{}", self.name), diff --git a/datafusion/src/logical_plan/plan.rs b/datafusion/src/logical_plan/plan.rs index 952572f4dea3..b40dfc0103fc 100644 --- a/datafusion/src/logical_plan/plan.rs +++ b/datafusion/src/logical_plan/plan.rs @@ -1027,7 +1027,7 @@ pub enum PlanType { } impl fmt::Display for PlanType { - fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { + fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { match self { PlanType::InitialLogicalPlan => write!(f, "initial_logical_plan"), PlanType::OptimizedLogicalPlan { optimizer_name } => { diff --git a/datafusion/src/physical_plan/expressions/mod.rs b/datafusion/src/physical_plan/expressions/mod.rs index a85d86708557..9ba7eaaea343 100644 --- a/datafusion/src/physical_plan/expressions/mod.rs +++ b/datafusion/src/physical_plan/expressions/mod.rs @@ -113,7 +113,7 @@ pub struct PhysicalSortExpr { } impl std::fmt::Display for PhysicalSortExpr { - fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { + fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result { let opts_string = match (self.options.descending, self.options.nulls_first) { (true, true) => "DESC", (true, false) => "DESC NULLS LAST", diff --git a/datafusion/src/physical_plan/functions.rs b/datafusion/src/physical_plan/functions.rs index df073b62c5b7..6bff76f010d6 100644 --- a/datafusion/src/physical_plan/functions.rs +++ b/datafusion/src/physical_plan/functions.rs @@ -1547,7 +1547,7 @@ pub struct ScalarFunctionExpr { } impl Debug for ScalarFunctionExpr { - fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result { + fn fmt(&self, f: &mut Formatter) -> fmt::Result { f.debug_struct("ScalarFunctionExpr") .field("fun", &"") .field("name", &self.name) diff --git a/datafusion/src/physical_plan/hash_aggregate.rs b/datafusion/src/physical_plan/hash_aggregate.rs index 9f8b7baf6fa2..f15e8f0fb47e 100644 --- a/datafusion/src/physical_plan/hash_aggregate.rs +++ b/datafusion/src/physical_plan/hash_aggregate.rs @@ -619,7 +619,7 @@ struct Accumulators { } impl std::fmt::Debug for Accumulators { - fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { + fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result { // hashes are not store inline, so could only get values let map_string = "RawTable"; f.debug_struct("Accumulators") diff --git a/datafusion/src/physical_plan/hash_join.rs b/datafusion/src/physical_plan/hash_join.rs index f683c58a28ea..39479f9485e5 100644 --- a/datafusion/src/physical_plan/hash_join.rs +++ b/datafusion/src/physical_plan/hash_join.rs @@ -91,7 +91,7 @@ use std::fmt; struct JoinHashMap(RawTable<(u64, SmallVec<[u64; 1]>)>); impl fmt::Debug for JoinHashMap { - fn fmt(&self, _f: &mut fmt::Formatter<'_>) -> fmt::Result { + fn fmt(&self, _f: &mut fmt::Formatter) -> fmt::Result { Ok(()) } } diff --git a/datafusion/src/physical_plan/memory.rs b/datafusion/src/physical_plan/memory.rs index 7faecb514644..15848c558916 100644 --- a/datafusion/src/physical_plan/memory.rs +++ b/datafusion/src/physical_plan/memory.rs @@ -48,7 +48,7 @@ pub struct MemoryExec { } impl fmt::Debug for MemoryExec { - fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { + fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { write!(f, "partitions: [...]")?; write!(f, "schema: {:?}", self.projected_schema)?; write!(f, "projection: {:?}", self.projection) diff --git a/datafusion/src/physical_plan/metrics/mod.rs b/datafusion/src/physical_plan/metrics/mod.rs index 7c59c8dddd76..089550cee5cf 100644 --- a/datafusion/src/physical_plan/metrics/mod.rs +++ b/datafusion/src/physical_plan/metrics/mod.rs @@ -76,7 +76,7 @@ pub struct Metric { } impl Display for Metric { - fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { + fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result { write!(f, "{}", self.value.name())?; let mut iter = self @@ -282,7 +282,7 @@ impl MetricsSet { impl Display for MetricsSet { /// format the MetricsSet as a single string - fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { + fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result { let mut is_first = true; for i in self.metrics.iter() { if !is_first { @@ -363,7 +363,7 @@ impl Label { } impl Display for Label { - fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { + fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result { write!(f, "{}={}", self.name, self.value) } } diff --git a/datafusion/src/physical_plan/metrics/value.rs b/datafusion/src/physical_plan/metrics/value.rs index 1caf13ee724c..6944aab3b0ab 100644 --- a/datafusion/src/physical_plan/metrics/value.rs +++ b/datafusion/src/physical_plan/metrics/value.rs @@ -45,7 +45,7 @@ impl PartialEq for Count { } impl Display for Count { - fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { + fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result { write!(f, "{}", self.value()) } } @@ -97,7 +97,7 @@ impl PartialEq for Time { } impl Display for Time { - fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { + fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result { let duration = std::time::Duration::from_nanos(self.value() as u64); write!(f, "{:?}", duration) } @@ -216,7 +216,7 @@ impl PartialEq for Timestamp { } impl Display for Timestamp { - fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { + fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result { match self.value() { None => write!(f, "NONE"), Some(v) => { @@ -416,7 +416,7 @@ impl MetricValue { impl std::fmt::Display for MetricValue { /// Prints the value of this metric - fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { + fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result { match self { Self::OutputRows(count) | Self::Count { count, .. } => { write!(f, "{}", count) diff --git a/datafusion/src/physical_plan/sorts/external_sort.rs b/datafusion/src/physical_plan/sorts/external_sort.rs index 175b2370410e..8550cb5ad433 100644 --- a/datafusion/src/physical_plan/sorts/external_sort.rs +++ b/datafusion/src/physical_plan/sorts/external_sort.rs @@ -176,7 +176,7 @@ impl ExternalSorter { } impl Debug for ExternalSorter { - fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result { + fn fmt(&self, f: &mut Formatter) -> fmt::Result { f.debug_struct("ExternalSorter") .field("id", &self.id()) .field("memory_used", &self.used()) diff --git a/datafusion/src/physical_plan/sorts/mod.rs b/datafusion/src/physical_plan/sorts/mod.rs index 5f2a21bb954f..3dda13b1a178 100644 --- a/datafusion/src/physical_plan/sorts/mod.rs +++ b/datafusion/src/physical_plan/sorts/mod.rs @@ -66,7 +66,7 @@ struct SortKeyCursor { } impl<'a> std::fmt::Debug for SortKeyCursor { - fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { + fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result { f.debug_struct("SortKeyCursor") .field("columns", &self.columns) .field("cur_row", &self.cur_row) @@ -232,7 +232,7 @@ pub(crate) struct SortedStream { } impl Debug for SortedStream { - fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { + fn fmt(&self, f: &mut Formatter) -> std::fmt::Result { write!(f, "InMemSorterStream") } } diff --git a/datafusion/src/physical_plan/sorts/sort_preserving_merge.rs b/datafusion/src/physical_plan/sorts/sort_preserving_merge.rs index e9c8e60daa80..fa49daf5a1a6 100644 --- a/datafusion/src/physical_plan/sorts/sort_preserving_merge.rs +++ b/datafusion/src/physical_plan/sorts/sort_preserving_merge.rs @@ -225,7 +225,7 @@ struct MergingStreams { } impl Debug for MergingStreams { - fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { + fn fmt(&self, f: &mut Formatter) -> std::fmt::Result { f.debug_struct("MergingStreams") .field("id", &self.id()) .finish() diff --git a/datafusion/src/physical_plan/udaf.rs b/datafusion/src/physical_plan/udaf.rs index 08ea5d30946e..974b4a9df764 100644 --- a/datafusion/src/physical_plan/udaf.rs +++ b/datafusion/src/physical_plan/udaf.rs @@ -56,7 +56,7 @@ pub struct AggregateUDF { } impl Debug for AggregateUDF { - fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result { + fn fmt(&self, f: &mut Formatter) -> fmt::Result { f.debug_struct("AggregateUDF") .field("name", &self.name) .field("signature", &self.signature) diff --git a/datafusion/src/physical_plan/udf.rs b/datafusion/src/physical_plan/udf.rs index 0c5e80baea31..af0765877c1b 100644 --- a/datafusion/src/physical_plan/udf.rs +++ b/datafusion/src/physical_plan/udf.rs @@ -54,7 +54,7 @@ pub struct ScalarUDF { } impl Debug for ScalarUDF { - fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result { + fn fmt(&self, f: &mut Formatter) -> fmt::Result { f.debug_struct("ScalarUDF") .field("name", &self.name) .field("signature", &self.signature) diff --git a/datafusion/src/scalar.rs b/datafusion/src/scalar.rs index cf6e8a1ac1c2..6f80e9b57780 100644 --- a/datafusion/src/scalar.rs +++ b/datafusion/src/scalar.rs @@ -2108,7 +2108,7 @@ impl fmt::Display for ScalarValue { } impl fmt::Debug for ScalarValue { - fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { + fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { match self { ScalarValue::Decimal128(_, _, _) => write!(f, "Decimal128({})", self), ScalarValue::Boolean(_) => write!(f, "Boolean({})", self),